On Wed, Oct 22, 2008 at 01:23:49PM +0200, Thomas <[EMAIL PROTECTED]> wrote:
> -build() {
> -     cd $Fsrcdir || Fdie
> -     mkdir $Fsrcdir/$pkgname || Fdie

(...)
> +             cd $Fsrcdir || Fdie
> +             mkdir $Fsrcdir/$pkgname

I don't see the purpose of this change.

The Fdie is right there, use "mkdir -p foo || Fdie" if you want to allow
an incremental build.

Also, prepending two tabs instead of one makes no sense to me.

Anyway it looks fine, but please don't push this one as-is now, as the
patch is quite unreadable because of these whitespace changes.

Please just resend a patch whithout whitespace changes, then probably
you'll earn my ACK. :)

PS: I just ignored your second mail, I hope it got it right that it was
just a duplicate.

Attachment: pgpEfL4VQ1ni2.pgp
Description: PGP signature

_______________________________________________
Frugalware-devel mailing list
[email protected]
http://frugalware.org/mailman/listinfo/frugalware-devel

Reply via email to