On Sat, Oct 17, 2009 at 09:53:10PM +0200, Laszlo Papp <[email protected]> wrote: > diff --git a/src/pacman-g2/pacman-g2.c b/src/pacman-g2/pacman-g2.c > index cf8642b..280447f 100644 > --- a/src/pacman-g2/pacman-g2.c > +++ b/src/pacman-g2/pacman-g2.c > @@ -1,9 +1,9 @@ > /* > * pacman-g2.c > - * > + * > * Copyright (c) 2002-2006 by Judd Vinet <[email protected]> > * Copyright (c) 2007-2008 by Miklos Vajna <[email protected]> > - * > + *
You are removing trailing whitespaces here. While it's not a bad change in its own, mixing cosmetic changes with functional changes is not allowed. Please split your patch into two: one whith cosmetic and one with functional changes. > + case OP_NOARCH: config->flags |= PM_TRANS_FLAG_NOARCH; > break; > + case OP_REGEX: config->regex = 1; break; > case 'A': config->op = (config->op != PM_OP_MAIN ? 0 : > PM_OP_ADD); break; > case 'D': > config->op = (config->op != PM_OP_MAIN ? 0 : > PM_OP_DEPTEST); This is in general not a bad idea, but OP_FOO AND PM_OP_FOO is not used for totally different purposes. What about using OPT_FOO instead?
pgpIfyqugUQCp.pgp
Description: PGP signature
_______________________________________________ Frugalware-devel mailing list [email protected] http://frugalware.org/mailman/listinfo/frugalware-devel
