On Thu, Mar 17, 2011 at 07:25:31PM +0100, Lord Fener <[email protected]> wrote: > Hello, > I noticed that the Fconfoptstryset doesn't recognize if an option is > available for some configure scripts, in fact seems that grepping the option > in the file returns nothing (i.e. the package lensfun, it does support the > --prefix option, but the function fails to recognize that). > I'd suggest to add further a check also on the ./configure -h (in wich seems > that all the options are listed), somethin like that:
Hi,
I see the motivation, but that will cause a lot of problem if
./configure does not support '-h'. So I would say:
1) use --prefix=$Fprefix in the FB of lensfun or
2) make the patch optional, like:
diff --git a/source/include/util.sh b/source/include/util.sh
index edec799..83e9901 100644
--- a/source/include/util.sh
+++ b/source/include/util.sh
@@ -772,7 +772,9 @@ Fconfoptstryset() {
# check if $_F_conf_configure supports it
if ! grep -q -- "--$1=" $_F_conf_configure; then
- return 1
+ if [ -z "$_F_conf_invoke" ] || ! $_F_conf_configure -h | grep
-q -- "--$1="; then
+ return 1
+ fi
fi
# check if it was not already set in $Fconfopts
(untested)
That way you could add _F_conf_invoke=1 to lensfun's FB and make sure
you don't break already existing builds.
Does that sound acceptable for you?
Thanks.
pgpK1ZHQqDRY8.pgp
Description: PGP signature
_______________________________________________ Frugalware-devel mailing list [email protected] http://frugalware.org/mailman/listinfo/frugalware-devel
