> Hi,
> I made a patch to enable the --regex option with pacman -R.
> Seems to work fine here, but please review it.
>
> Melko

Hi,
2 comments:
- You forgot to change the --help and manual (maybe --regex is should go
to general options since it's quite usable to any target but upgrade).
Vmiklos comment on this?
- Since it is quite exactly the same as in sync (and quite all the other
commands if first comment is accepted) maybe we should share the searching
code based on regex somewhere, and make it generic with a call back?

Else the code looks fine (thought the --help must be updated what-ever is
decided about my comments).

_______________________________________________
Frugalware-devel mailing list
[email protected]
http://frugalware.org/mailman/listinfo/frugalware-devel

Reply via email to