On Mon, Dec 15, 2014 at 10:47:23AM -0500, Theodore Ts'o wrote:
> These tests use the falloc command in xfs_io, and there are some file
> systems (ext3) or file system configurations (ext4 in ext3
> compatibility mode) which do not support fallocate. So add the
> explicit requirement to avoid false test failures.
The two tests fail because of no defrag support on ext3 on my test host.
ext4/308 [not run] defragmentation not supported for fstype "ext3"
generic/324 19s ... [not run] defragmentation not supported for fstype "ext3"
But the check makes sense to me.
>
> Signed-off-by: Theodore Ts'o <[email protected]>
> ---
> tests/ext4/308 | 1 +
> tests/generic/324 | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/tests/ext4/308 b/tests/ext4/308
> index 8df24ba..948ff3f 100755
> --- a/tests/ext4/308
> +++ b/tests/ext4/308
> @@ -46,6 +46,7 @@ _supported_os Linux
> _need_to_be_root
> _require_scratch
> _require_defrag
> +_require_xfs_io_command "falloc"
ext4/308 also uses fiemap command, I think we need another check here
_require_xfs_io_command "fiemap"
Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
