On Tue, Dec 16, 2014 at 01:09:26AM +0800, Eryu Guan wrote: > Tests like xfs/179 depend on the return value of _check_scratch_fs to > detect fs corruption, but _check_$FSTYP_filesystem always returns 0.
which means xfs/179 is wrong, because when _check_scratch_fs fails it exits immediately with status = 1, which triggers the test harness to record a test failure. (i.e. xfs/179 != check, so exits) So this change is not actually going to allow tests to check the return value of _check_scratch_fs, and check itself doesn't care if the filesystem is corrupt or not - it just reports the state and moves on to the next test.... > Also don't exit if these functions called by 'check', like what > _check_xfs_filesystem() does. That's a separate issue, and should be in it's own patch ;) Cheers, Dave. -- Dave Chinner [email protected] -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
