The change is fine - the reformating of the code is not. 8 space
tabs
To be clear, do you mean 8 spaces or single tabs?
Single tab, but tabs are the width of 8 spaces. Same as you'd use
for writing new kernel code.
Even I was confused by that :) Just use tabs not spaces. Width of the
tab is whatever your editor decides it is
Exactly :)
so it's irrelevant :)
Well, unfortunately many use tabs for alignment as well as indentation
so changing the width of a tab can make code look ugly where there are
line continuations, aligned comments, etc. Using tabs for indentation
and spaces for alignment is ideal, but tabs-for-alignment is so common
that assuming tabs are always displayed 8 characters wide is often the
pragmatic option.
Andy
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
