On 12/4/15 10:00 AM, Zorro Lang wrote: > There're two bugs on xfsprogs: > 1. when a project name beinning with digits, it can't be found > by run xfs_quota 'quota -p -v ...' command, but 'report' command > can find it. > > 2. When user or group names beginning with digits, we can't > create 'limit' for them, and can't find them either(likes above). > > This case will create user, group and project names which beginning > with digits, then create limit for them, and query them. > > Signed-off-by: Zorro Lang <[email protected]> > --- > > Hi, > > This case need a test user, that doesn't like user 'fsqa', fsqa is a > common user for xfstests, but this case need a special and temporary > user and group. So I create and clean them in this case. > > But this's the first time a xfstests case add test user/group by itself, > so please help to review, if this's appropriate?
So, I came to the conclusion, and talking w/ Dave I think he concurs, that it would be better to document the need for these users in the README; then, just like the "fsgqa" user, your test can check for the existence of i.e. a "123456-fsgqa" user, and simply _notrun() if it's not present. This way /etc/passwd stays under the system administrator's control, but it's clear why the test is skipped if the user doesn't exist. -Eric -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
