It was 03/11/2006 20:29, when Niklas Gustavsson wrote:
> Possibly a simpler solution would be to make props and prefix protected
> fields. That would be a similar solution as adding setter and getters
> for them, but possibly simpler and more targeted for subclassing. What
> do you think?
Niklas
Yes, that's fine also. It's just a habit of mine, keeping all
variables private.
I've also marked the default constructor as protected, so that any
subclasses can make use of it, should any default setup be added in
there at a later date.
New patch attached.
- Dave.
Index: src/java/org/apache/ftpserver/config/PropertiesConfiguration.java
===================================================================
--- src/java/org/apache/ftpserver/config/PropertiesConfiguration.java
(revision 470756)
+++ src/java/org/apache/ftpserver/config/PropertiesConfiguration.java
(working copy)
@@ -37,13 +37,13 @@
public
class PropertiesConfiguration implements Configuration {
- private Properties prop;
- private String prefix = "config.";
+ protected Properties prop;
+ protected String prefix = "config.";
/**
- * Private constructor - used internally to get configuration subset.
+ * Default constructor - used internally to get configuration subset.
*/
- private PropertiesConfiguration() {
+ protected PropertiesConfiguration() {
}
/**
