Clinton Foster wrote:
Yes, this appears to be a good general solution. At least for my purposes,
this would eliminate the need for Ftplet.onLoginFail().
Great! We'll leave with this patch then for now.
I intended to test the patch before replying, but I ran into a hitch due to
my unfamiliarity with Apache projects: I attempted to apply the patch to a
copy of the source obtained from the Download link on the Apache FTP Server
home page. This worked well until I got to ServerFtpStatistics.java, which
doesn't exist in that version of the source. I do see it in the Subversion
repository. This raises the question: How often is the source from the
repository packaged into the zip and tar files available from the Download
link?
Pretty much never. You should always work from the code that is in SVN.
By the way, I have made some changes myself that may be of general interest,
such as the addition of an IThreadFactory interface. I gather the first step
for submitting these is to create an issue and attach some kind of
standardized diff output representing the change. I assume subversion has a
tool for doing this, but I could some tips regarding the overall procedure
for submitting changes. If you can direct me to further information, I would
appreciate it.
You will find quite a lot of info on how to create patches here:
http://apache.org/dev/contributors.html#patches
I'll be happy to help you with any questions or problems that you run
into. We're very happy to receive patches that improve the code base.
/niklas
