[
https://issues.apache.org/jira/browse/FTPSERVER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niklas Gustavsson closed FTPSERVER-83.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.0-M2
Assignee: Niklas Gustavsson
commit -m "Implemented a configurable external passive address (FTPSERVER-83)
as suggested by Clinton Foster"
C:/home/niklas/workspaces/apache/ftpserver/ftplet-api/src/java/org/apache/ftpserver/ftplet/AuthenticationFailedException.java
C:/home/niklas/workspaces/apache/ftpserver/ftplet-api/src/java/org/apache/ftpserver/ftplet/DataConnection.java
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/command/EPRT.java
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/command/EPSV.java
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/command/PASV.java
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/command/PORT.java
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/DataConnectionException.java
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/DefaultDataConnectionConfig.java
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/interfaces/DataConnectionConfig.java
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/IODataConnectionFactory.java
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/listener/mina/FtpRequestDecoder.java
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/ServerDataConnectionFactory.java
C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/clienttests/PasvAddressTest.java
C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/clienttests/PasvAddressWithHostnameTest.java
C:/home/niklas/workspaces/apache/ftpserver/distribution/res/conf/ftpd.properties
C:/home/niklas/workspaces/apache/ftpserver/distribution/res/conf/ftpd.xml
Sending
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/command/EPRT.java
Sending
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/command/EPSV.java
Sending
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/command/PASV.java
Sending
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/command/PORT.java
Adding
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/DataConnectionException.java
Sending
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/DefaultDataConnectionConfig.java
Sending
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/interfaces/DataConnectionConfig.java
Sending
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/IODataConnectionFactory.java
Deleting
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/listener/mina/FtpRequestDecoder.java
Sending
C:/home/niklas/workspaces/apache/ftpserver/core/src/java/org/apache/ftpserver/ServerDataConnectionFactory.java
Adding
C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/clienttests/PasvAddressTest.java
Adding
C:/home/niklas/workspaces/apache/ftpserver/core/src/test/org/apache/ftpserver/clienttests/PasvAddressWithHostnameTest.java
Sending
C:/home/niklas/workspaces/apache/ftpserver/distribution/res/conf/ftpd.properties
Sending
C:/home/niklas/workspaces/apache/ftpserver/distribution/res/conf/ftpd.xml
Sending
C:/home/niklas/workspaces/apache/ftpserver/ftplet-api/src/java/org/apache/ftpserver/ftplet/AuthenticationFailedException.java
Sending
C:/home/niklas/workspaces/apache/ftpserver/ftplet-api/src/java/org/apache/ftpserver/ftplet/DataConnection.java
Transmitting file data ...
Committed revision 535345.
> Allow configuring IP address for PASV response
> ----------------------------------------------
>
> Key: FTPSERVER-83
> URL: https://issues.apache.org/jira/browse/FTPSERVER-83
> Project: FtpServer
> Issue Type: Improvement
> Components: Core
> Reporter: Clinton Foster
> Assigned To: Niklas Gustavsson
> Priority: Minor
> Fix For: 1.0-M2
>
> Attachments: FTPSERVER-83_diffs.zip
>
>
> Currently there is no way to configure the IP address returned in response to
> the PASV command. The config.data-connection.passive.address parameter allows
> configuring the local network interface where data connections should be
> accepted. But if the server is behind a firewall, the address it returns to
> the client must be an external address, not a local address like 10.10.1.2.
> The current code will only work with firewalls that are smart enough to sniff
> the control connection and automatically rewrite the correct external address
> in PASV responses. But it won't work if the control connection is running
> over SSL. To handle the SSL case (and the unsophisticated firewall case) a
> new configuration parameter is needed. I would suggest calling it
> config.data-connection.passive.external-address.
> Ideally, the server should notice if the client's control connection came
> from a local address, and if so return the local address instead of the
> external address. This allows local clients to make passive data connections
> to the server even if the external address is not resolvable for them. JDK
> 1.4 provides methods on InetAddress for making this determination, such as
> isLinkLocalAddress().
> I am going to attach a patch for the pre-MINA code base from early January
> (2007). When I update to the latest code base I can attach an updated patch
> if this patch hasn't been incorporated by that time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
