Thats fine with me, I agree with your intent to introduce Spring or make the
core "inversion of controllable".
It would certainly make life easier in the area of configuration.
Although I prefer setting up things using Spring it's probably a good idea
to maintain the Configuration constructor for those that
will use the ConfigurableFtpServerContext, but then of course use the
Commons Configuration instead. The current Configuraiton interface is a
subset of the on defined in Commons so that should not be much of an issue.
I'll do my own plumbing for now and if time permits provide a patch in a
later stage and introduce Spring when suitable.
Thanks for your valuable information.
Curt Johansson
----- Original Message -----
From: "Niklas Gustavsson" <[EMAIL PROTECTED]>
To: <[email protected]>; <[EMAIL PROTECTED]>
Sent: Monday, April 14, 2008 9:55 PM
Subject: Re: Configuration implementation is removed
Hi Curt,
On Mon, Apr 14, 2008 at 4:36 PM, <[EMAIL PROTECTED]> wrote:
Hi,
as of lately the implementation of the interface org.apache.ftpserver.
ftplet.Configuration that used to be in ftpserver has been removed.
It wasn't removed but rather moved to the server module. However, as I
would like to drop our home grown IoC engine I'm planning on dropping
it from trunk in the neat future. To briefly describe the new "server"
module it's use is for those running FtpServer as a standalone server
(based on file based configuration). The "core" module is aimed for
embedding of FtpServer, the "normal" way of setting up FtpServer in
this case would be using the Java classes directly or using your
favorite IoC framework. I'm just in the process of adding namespace
handler to support Spring better.
The problem though is that the org.apache.ftpserver.ftplet.
Configuration interface in its constructor. I'd like to use a Commons
configuration class when I create the ftpserver instance in my app so I
suggest either that the org.apache.ftpserver.ftplet.Configuration is
extended from the org.apache.commons.configuration.Configuration or the
ConfigurableFtpServerContext is changed. Can this be easily done or do
I have to do my own plumbing?
I was not planning to provide an implementation for the configuration
based on Commons Configuration, but if you or someone else would
submit a patch for one I would be happy to accept it. However, it
should not be based of the current Configuration interface as that is
planned to be removed as I get further into removing our IoC framework
(of which it is part). Instead, it should set up the components using
the Java classes directly or someone similar.
Sorry if all these major changes to trunk is confusing. I'm trying to
do them one step at a time without breaking the build or doing huge
commits every other week :-)
/niklas
