Le 10/10/2013 22:09, Franck Villaume a écrit :
Hi everyone,

Currently Marc-Etienne started a hard work to reduce number of strings to be translated.
But some commits makes me wonder if there is a clear direction.
To make myself clear : I'm not against this initiative, I'm just wondering if we could improve it by using some standard rules.

Here are some questions.
Feel free for any feedback.


1) Dropping or adding punctuation ?

This commit drops the ending dot.

Modified: trunk/src/www/frs/admin/editrelease.php
===================================================================
--- trunk/src/www/frs/admin/editrelease.php 2013-10-10 14:16:46 UTC (rev 18200) +++ trunk/src/www/frs/admin/editrelease.php 2013-10-10 14:19:12 UTC (rev 18201)
@@ -274,7 +274,7 @@
 <tr>
     <td colspan="2">
         <br />
- <input type="checkbox" name="preformatted" value="1" <?php echo (($frsr->getPreformatted())?'checked="checked"':''); ?> /> <?php echo _('Preserve my pre-formatted text.') ?> + <input type="checkbox" name="preformatted" value="1" <?php echo (($frsr->getPreformatted())?'checked="checked"':''); ?> /> <?php echo _('Preserve my pre-formatted text') ?>
         <p>
<input type="submit" name="submit" value="<?php echo _('Submit/Refresh') ?>"/>
         </p>

That one adds a ending dot :

Modified: trunk/src/common/frs/FRSFile.class.php
===================================================================
--- trunk/src/common/frs/FRSFile.class.php      2013-10-04 12:39:12 UTC (rev 
18111)
+++ trunk/src/common/frs/FRSFile.class.php      2013-10-04 12:55:03 UTC (rev 
18112)
@@ -118,19 +118,19 @@
         */
        function 
create($name,$file_location,$type_id,$processor_id,$release_time=false) {
                if (strlen($name) < 3) {
-                       $this->setError(_('FRSFile Name Must Be At Least 3 
Characters'));
+                       $this->setError(_('Name is too short. It must be at 
least 3 characters.'));'));
                        return false;
                }


the next one is a wrong copy-paste...

Modified: trunk/src/www/include/user_home.php
===================================================================
--- trunk/src/www/include/user_home.php 2013-10-09 10:23:51 UTC (rev 18181) +++ trunk/src/www/include/user_home.php 2013-10-09 14:03:00 UTC (rev 18182)
@@ -86,7 +86,7 @@

 <?php

-    echo $HTML->boxMiddle(_('Project Info'), _('Project Info'));
+echo $HTML->boxMiddle(_('Project Information'), _('Project Information'));

 $projects = $user->getGroups () ;
 sortProjectList ($projects) ;


2) Using "Admin" or "Administration" aka short or complete word ?

Here, goes to shorter word.

Modified: trunk/src/common/include/Navigation.class.php
===================================================================
--- trunk/src/common/include/Navigation.class.php 2013-10-10 14:19:12 UTC (rev 18201) +++ trunk/src/common/include/Navigation.class.php 2013-10-10 14:40:01 UTC (rev 18202)
@@ -395,7 +395,7 @@
             // Project Admin
             if (forge_check_perm ('project_admin', $group_id)) {
                 $menu['titles'][] = _('Admin');
-                $menu['tooltips'][] = _('Project Administration.');
+                $menu['tooltips'][] = _('Project Admin');
$menu['urls'][] = util_make_uri('/project/admin/?group_id=' . $group_id);
                 $menu['adminurls'][] = false;
                 if ($toptab == "admin") {

Here goes to complete word.

Modified: trunk/src/www/include/user_home.php
===================================================================
--- trunk/src/www/include/user_home.php 2013-10-09 10:23:51 UTC (rev 18181) +++ trunk/src/www/include/user_home.php 2013-10-09 14:03:00 UTC (rev 18182)
@@ -86,7 +86,7 @@

 <?php

-    echo $HTML->boxMiddle(_('Project Info'), _('Project Info'));
+echo $HTML->boxMiddle(_('Project Information'), _('Project Information'));

 $projects = $user->getGroups () ;
 sortProjectList ($projects) ;

3) Using Uppercase or not ?

Adding Uppercase here :

Modified: trunk/src/www/forum/admin/index.php
===================================================================
--- trunk/src/www/forum/admin/index.php 2013-10-10 13:46:10 UTC (rev 18195) +++ trunk/src/www/forum/admin/index.php 2013-10-10 13:50:30 UTC (rev 18196)
@@ -243,7 +243,7 @@
         //actually finish editing the message and save the contents
         $f = new Forum ($fa->GetGroupObject(),$forum_id);
         if (!$f || !is_object($f)) {
-            exit_error(_('Error getting forum'),'forums');
+            exit_error(_('Error getting Forum'),'forums');
         } elseif ($f->isError()) {
             exit_error($f->getErrorMessage(),'forums');
         }
@@ -282,7 +282,7 @@

         $f = new Forum ($fa->GetGroupObject(),$forum_id);
         if (!$f || !is_object($f)) {
-            exit_error(_('Error getting forum'),'forums');
+            exit_error(_('Error getting Forum'),'forums');
         } elseif ($f->isError()) {
             exit_error($f->getErrorMessage(),'forums');
         }


Modified: trunk/src/plugins/oauthprovider/www/index.php
===================================================================
--- trunk/src/plugins/oauthprovider/www/index.php 2013-10-09 10:09:38 UTC (rev 18176) +++ trunk/src/plugins/oauthprovider/www/index.php 2013-10-09 10:10:13 UTC (rev 18177)
@@ -71,7 +71,7 @@
 <?php
 $link_param = '?type='.$type.'&'.$type_param[0].'='.$type_param[1];
echo util_make_link('/plugins/'.$pluginname.'/consumer.php', _('Consumers')). ' <br />'; -echo util_make_link('/plugins/'.$pluginname.'/request_tokens.php'.$link_param, _('Request tokens')).'<br /> '; +echo util_make_link('/plugins/'.$pluginname.'/request_tokens.php'.$link_param, _('Request Tokens')).'<br /> '; echo util_make_link('/plugins/'.$pluginname.'/access_tokens.php'.$link_param, _('Access tokens')).'<br /> ';



Dropping Uppercase there :
(And using admin lowercase, while in the "Administration vs. Admin" the commit shows Admin uppercase)

Modified: trunk/src/plugins/extsubproj/include/extsubprojPlugin.class.php
===================================================================
--- trunk/src/plugins/extsubproj/include/extsubprojPlugin.class.php 2013-10-10 08:10:23 UTC (rev 18185) +++ trunk/src/plugins/extsubproj/include/extsubprojPlugin.class.php 2013-10-10 08:13:07 UTC (rev 18186)
@@ -73,7 +73,7 @@
     * @access    public
     */
     function getProjectAdminLink($group_id) {
- return util_make_link('/plugins/'.$this->name.'/?group_id='.$group_id.'&type=admin&pluginname='.$this->name, _('External subprojects Admin'), array('class'=>'tabtitle', 'title'=>_('Configure the External subprojects plugin'))); + return util_make_link('/plugins/'.$this->name.'/?group_id='.$group_id.'&type=admin&pluginname='.$this->name, _('External subprojects admin'), array('class'=>'tabtitle', 'title'=>_('Configure the External subprojects plugin')));
     }
     function getProjectAdminAddExtSubProjAction($group_id) {
return '?group_id='.$group_id.'&type=admin&pluginname='.$this->name.'&action=addExtSubProj';



You can enhance the translation rules by editing the page :
https://fusionforge.org/plugins/mediawiki/wiki/fusionforge/index.php/Translations

And maybe help Marc-Etienne which is doing a really hard work.
Any opinion ?

Regards,

Franck aka nerville.



_______________________________________________
Fusionforge-general mailing list
[email protected]
http://lists.fusionforge.org/cgi-bin/mailman/listinfo/fusionforge-general


--
TrivialDev Founder
http://trivialdev.com

<<attachment: franck_villaume.vcf>>

_______________________________________________
Fusionforge-general mailing list
[email protected]
http://lists.fusionforge.org/cgi-bin/mailman/listinfo/fusionforge-general

Reply via email to