Hi Dan, On Sat, Jul 04, 2020 at 03:19:18PM -0400, Dan Espen wrote: > Thomas Adam <tho...@fvwm.org> writes: > > I've looked at other examples in fvwm such as FvwmAnimate, FvwmAuto, and > > none > > of them are doing anything different to MX_* packet handling, to what I'm > > trying to do. > > > > If anyone has any thoughts, I'd appreciate it.
Well, aren't I silly?! :) Turns out, things were working fine, it's just that my matching was off -- I wasn't taking in to account the ordering of the checks I was performing was putting MX_* checks last, so it was matching the non MX_* counterparts. Oops. Fixed now. > I'm the culprit that added module message masks. > My intent that modules could select the messages they want. Which was definitely the right thing to do, Dan. Even now, MX_* messages are sent to all modules, for instance. I know that BroadcastPacket() without a module mask makes sense for some packets, but I'd argue that pretty much every module in Fvwm will only care about those packets set by SetMessageMask() and friends. > I didn't add the MX part, that must have been someone else. > Since the MX flags are in a different word, perhaps modules should be > clearing both words before they set anything. I think you're right here. It probably makes sense to set one large bitmask, as you say, and then deprecate broadcast mode to all modules, except for the signal to kill them. This makes SetMessageMask() much more useful, and reduced the traffic sent down the pipes in the first place. > I'm not sure why this wasn't done with one large bit mask like the style > flags were done. Presumably it was easier to augment what was there, rather than break other modules? That said, I'm not aware of anyone ever having written a Fvwm module which actually links against libfvwm, so I might be wrong. Hope everyone's well. Here in the UK, we're officially allowed out to a pub and other places. But I'm staying clear of all of those for now -- we're likely days away from either a local lockdown or a second national wave of Covid-19. I don't want to be undoing the hardwork I've put in to remaining healthy! Cheers again! Thomas
