(Please reply always to the mailing list, not to me in person). On Tue, Jul 26, 2005 at 04:03:02AM +0200, Marc Lehmann wrote: > On Fri, Jul 22, 2005 at 06:49:59PM +0200, Johannes Kneer <[EMAIL PROTECTED]> > wrote: > > On Sun, Jul 17, 2005 at 06:12:38PM +0200, Johannes Kneer wrote: > > [snip] > > > Marc also has done a quick and dirty patch, that simply replaces all > > > occurences of CARD32 by long. This might not have fixed eveything but > > > works for me, as firefox, mozilla, etc open again their main windows. > > > (http://data.plan9.de/fvwm.64bit-fixes.diff) > > > > > > Please CC us on reply as we're not subscribed to the list. > > > > I've committed a patch to CVS to deal with the problems with > > XChangeProperty and XGetWindowProperty, but currently I have no > > way to test it. > > Well, it's not too hard: if, after getting rid of CARD32 (whose occurrence > is likely to be wrong anywhere) and replacing it by long (when X*Property > is involved) should magically fix everything. (I saw a few less-simple > cases in the diff, though, and I think it would be easier to store > cardinals or any format-32 variables in "long" variables instead of > converting them dynamically, as the latter is prone to errors. That would > also catch such errors earlier, I think).
Agreed. There was some complicated code that in ewmh.c and gnome.c to translate the number of bytes returned into the length and positions of the proper data type. Hence the non trivial changes that caused me some headache. > > Can you please try the latest CVS-snapshot and > > tell me if that helps? > > Before the patch (with mine still applied, but that one didn't touch > everything): > > _WIN_AREA(CARDINAL) = 0, 1 > With current CVS: > _WIN_AREA(CARDINAL) = 0, 1 > > Hard to see wether this is correct, though, as on little-endian systems there > is no different between passing a single 64 or 32-bit type, so the only thing > I can see is that "_WIN_AREA" seems to work. That's fine - I needed confirmation only for one of these items, not for all of them. Same is true for the ewmh properties. [snip] > (current cvs): > _NET_WM_PID(CARDINAL) = 374 [snip] > Thanks for taking care of this issue :) The miracle of "mozilla is no longer > opening a window" was mesmerizing us for weeks... :) Great. I'll have my AMD64 system up soon to take a look at any possible problems in the module interface. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED]
signature.asc
Description: Digital signature
