On Sun, Aug 07, 2005 at 10:58:15AM +0200, Viktor Griph wrote: > I've written a menu style option to allow for scrolling of menus with a > mouse wheel.
> I also fixed two obvious copy-past-programming errors. I've extracted the fixes from the patch and committed them, but please provide separate patches for fixes and new features if possible. It looks like this new feature works only with the mouse. It's a strict rule that *everything* that can be done in menus mut be possible using the keyboard. Can you please add something to the menuShortcuts() function that allows using keys? This also has the side effect that I can try the new feature (which is essential as I am not going to commit menu features that I can not test :-)). In the man page you write that Menustyle ... Scroll is equivalent to Menustyle ... Scroll On This is not good. In the MenuStyle command, omitting the argument of an option should restore the default value, and the man page should explicitly say so. > Could someone with cvs wrilte-access apply this patch? I'd first like to understand what the patch does exactly. Please elaborate on how the new feature works. Some comments below in the quoted parts. > + for (next = miCurrent; next && (! MI_IS_SELECTABLE(next) || next == > miCurrent ); > + next = (direction == 1) ? MI_NEXT_ITEM(next) : > MI_PREV_ITEM(next)) > + ; /* maybe use while... */ Please stick to 79 characters per line. > + FWarpPointer(dpy, 0, 0, 0, 0, 0, 0, 0, > menu_y-event->xbutton.y_root + MI_HEIGHT(next)/2 + MI_Y_OFFSET(next)); Dito! Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED]
signature.asc
Description: Digital signature
