On Sun, 18 Sep 2005, Mikhael Goikhman wrote:
On 18 Sep 2005 21:17:39 +0200, Viktor Griph wrote:
On Sun, 18 Sep 2005, Mikhael Goikhman wrote:
Actually, this patch is a bit conservative and expands less than I would
like to. For example, $[fg.cs$d] and $[gt.$n] are always expanded (this
is correct although makes no much sence), but $[UNEXISTING_$[desk.n]_VAR]
is left as is. I would expect it to possibly become $[UNEXISTING_0_VAR].
That wouldn't be that hard to change. Maybe will get some time this week
to look at it, but today I have no time for it.
I planned to commit this patch, because I saw several configs that use
tricks to do $[desk.name$[desk.n]]. BTW, this is already possible using:
Just hold on for a while. [...] I'll try to find sometime this week to
check on this.
Since I already have this patch applied and changed it a bit (among other
things making it pass s compilation with gcc 4.0), I prefer to commit it
tomorrow (giving a chance to object). So I don't need to redo my changes.
In that case commit it. I just believe that I didn't freeded a varable
returned by expand_vars, thus having a memory leak. Could you check so
that the var_name is freed at the end of epand_vars_extended if it isn't
already?
/Viktor
