>>>>> On Sat, 05 Jan 2002 09:40:33 -0500
>>>>> "Dan" == Dan Espen <[EMAIL PROTECTED]> wrote:
Dan> 
>> BTW there is a mistake in fvwm/read.c
>> 
>> fvwm_msg(DBG,"ReadSubFunc","Module switch %d, about to exec: '%.*s'",
>> Module,strlen(tline)-1,tline);
>> 
>> strlen should not be subctracted by 1.
Dan> 
Dan> That was put in there because tline had a newline.
Dan> I guess you are seeing lines that don't have newlines.

no I saw (when run fvwm -debug) lines without last significant
character, like "fvw" instead of "fvwm". This is case of
null-terminated string. If it is not terminaded strlen() result is
rather undefined.

Due to tline construction it cannot contain any '\n' and is null
terminated, so, anyway your conclusion about the fix is right.

Dan> Someone must have fixed something.
Dan> 
Dan> If the newline is gone, the right fix would be to remove the strlen
Dan> and the ".*".


-- 
Alexander Kotelnikov
Saint-Petersburg, Russia
--
Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]

Reply via email to