On 03 Mar 2004 12:01:19 +0100, Arne Georg Gleditsch wrote: > > * Mikhael Goikhman > > I think WindowNameSuffix is not a good solution to the problem. We should > > use existing window field visible_name for this and have a new command > > like WindowNameFormat (just escape "$" if run under window context): > > > > WindowNameFormat "( $[w.name] )" > > > > (or VisibleWindowNameFormat). > > I'm not sure I follow you. The patch given hooks into the update path > for visible_name, and appends the fixed suffix where applicable. If I > were to implement your proposal (which I like), I would do it much the > same way, calling expand_vars (?) at the same point in the update path > for visible_name instead of just appending a fixed string. > It's not clear to me from your wording if you would like to se > visible_name itself be the format string, and expand it when used, or > if an implementation as the above, where visible_name is the expanded > string, would be acceptable.
With my suggestion you don't need to modify FvwmWindow structure. The suggested WindowNameFormat may be either a global command or a style option, but not a window context command like yours. Then this format string would be stored either globally or in style structure. visible_name contains the final name after expansion just like now. There are other problems with your patch, the command without parameter should remove the string (the default is to use name for visible_name). Your patch also leaks memory, i.e. it does not free the string when a window is closed, AFAICS. (With my suggestion there is nothing to free.) Regards, Mikhael. -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
