--On Sunday, May 09, 2004 12:17:48 +0100 Tavis Ormandy <[EMAIL PROTECTED]> wrote:
>
>
> --On Saturday, May 08, 2004 22:53:27 +0000 Mikhael Goikhman
> <[EMAIL PROTECTED]> wrote:
>
>> IMHO, the Test condition should default to true just like with all other
>> conditional commands.
>
> I see, how about changing the test for "True" to check for "False"?
Maybe I should expand on that, for example, right now:
Test (True) This will happen
Test (False) This will happen
Test (Blahblahblah) This will happen
but True is still tested for as an on-condition, if this was changed to
check for False and set match accordingly:
Test (True) This will happen
Test (False) This wont happen
Test (Blahblahblah) This will happen
so Test still defaults to a match, what do you think?
$ cvs diff conditional.c
Index: conditional.c
===================================================================
RCS file: /home/cvs/fvwm/fvwm/fvwm/conditional.c,v
retrieving revision 1.92
diff -u -w -r1.92 conditional.c
--- conditional.c 2 Apr 2004 12:09:33 -0000 1.92
+++ conditional.c 9 May 2004 11:59:33 -0000
@@ -1608,9 +1608,9 @@
on = 0;
cond++;
}
- if (StrEquals(cond, "True"))
+ if (StrEquals(cond, "False"))
{
- match = True;
+ match = False;
}
else if (StrEquals(cond, "Version"))
{
--
-------------------------------------
[EMAIL PROTECTED] | finger me for my gpg key.
-------------------------------------------------------
pgpOcLGwQ7xGI.pgp
Description: PGP signature
