On 2/2/06, Dominik Vogt <[EMAIL PROTECTED]> wrote:
> So, the work can be split into several smaller steps:
>
> 1. Make all the modules use ParseModuleArgs() and copy the fds
>    from the ModuleArgs struct to the arrays that are currently
>    used by the modules.
> 2. Remove the fd arrays in the modules and use the fds in the
>    ModuleArgs instead.
> 3. Make the service functions in Module.c use a (const ModuleArgs *)
>    instead of passing individual arguments and adapt the modules.
>

FvwmAnimate is mostly done for the 1st item in the list. I also made
the code use the struct->name instead of the char *MyName global var.

As for what isn't done yet in this module: FvwmAnimate uses some
macros (yuch!) for the communication with fvwm. I used CatString3()
for the places where we need the * char before the module name, but I
really don't know what to do in with the macros. I thought of making
them inline functions, but I would like to know what you think..
Search for "these macros are not done yet" in the patch and you will
find it.

With that problem aside, I hope FvwmAnimate users could test the new
code to see if it works ok. Note that it is _not_ working right now
because of those macros.

Cheers!
  Renato Caldas

Reply via email to