On Fri, Feb 10, 2006 at 11:37:29AM +0300, George 'Nephrite' Potapov wrote: > Looks like Mikhael committed cleaned up version of FvwmButtons so I'm > resubmitting my patch for button press simulation. I cleaned the code up as > requested.
I have committed the patch. Some random comments, but nothing
really important.
* The patch to the Loop() function did not apply to current CVS,
but it was easy to fix.
* You changed the wrong ChangeLog. There is a modules/ChangeLog
file too.
* The mousebutton variable was used uninitialized if
GetQuotedString returned NULL.
* The text length in the NEWS file is limited to 66 characters
(Just stop before the text exceeds the length of the dashed
lines).
* It would be nice to include the funtion names in ChangeLog
entries too. That helps a lot to find out when some bug
appeared. It was pretty easy to do manually with yout patch.
> + rest = GetQuotedString(rest, &buttonn, "", NULL, NULL, NULL);
> + if (buttonn)
> + {
> + mousebutton = atoi(buttonn);
> + free(buttonn);
> + }
else
{
mousebutton = 1;
}
> + if (mousebutton<= 0 ||
> + mousebutton > NUMBER_OF_EXTENDED_MOUSE_BUTTONS)
> + mousebutton = 1;
...
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt, [EMAIL PROTECTED]
signature.asc
Description: Digital signature
