On Wed, Feb 22, 2006 at 03:14:34PM -0700, Steven Taschuk wrote: > The configure script of fvwm 2.5.16 attempts to detect the versions > of various packages installed and to verify that they are of an > acceptably recent version. The code misparses version numbers that > have more than three components. > > For example, on my machine the problem arises with Xft: > > $ ./configure > [ ... several lines omitted ... ] > checking for Xft - version >= 2.0.0... ./configure: line 10146: test: > 2.2: integer expression expected > ./configure: line 10149: test: 2.2: integer expression expected > yes > [ ... several lines omitted ... ] > > Here's how it happens: The version number is detected by running > xft-config --version, then parsing the output with a sed script: > > $ sed -n '1405,1406p' fvwm-2.5.16/acinclude.m4 > xft_config_major_version=`$XFT_CONFIG $xft_config_args --version | \ > sed 's/\([[0-9]]*\).\([[0-9]]*\).\([[0-9]]*\)/\1/'` > > (With similar code on subsequent lines, and elsewhere for other > packages.) The sed script replaces a three-part version number such > as 2.0.1 with just its first component. However, on my system we have > > $ xft-config --version > 2.1.2.2 > > The sed replaces the leading "2.1.2" with "2", resulting in "2.2", > which confuses the subsequent comparison with the minimum required > major version number. > > Perhaps something like > xft-config --version | cut -d. -f1 > (and the like) would be more robust; the attached patch to acinclude.m4 > implements this notion, both for the xft autodetection and in the > similar code for gtk, imlib, freetype2, and fontconfig.
Thanks for the patch. I have rewritten the sed-expressions based on it as I don't want to introduce a new tool in the configure process (i.e. I want to avoid 'cut'). Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED]
signature.asc
Description: Digital signature
