On Thu, Jun 15, 2006 at 09:30:17AM +0200, Dominik Vogt wrote: > It actually wasn't this bad. The idea behing the test in the > ButtonReleasee handler was to make sure the window is snapped if > the window did not move before, but the pointer position in the > release event moved the window. > > In my eyes, the window should not move at all if the pointer does > not move (i.e. the user changes her mind or is just playing with > the mouse, as I often do). ==> The window should not be snapped > > The patch I have just committed makes sure the ButtonRelease > applies the snapped position, even if the pointer did not move.
ok > Initial snapping in your patch was flawed because it ignored the > do_snap flag which was not set at that time (you'd have to query > the X server for it). I thought snapping should always start out on, which is what nosnap_enabled is about. That's why I snapped unconditionally. But maybe I misunderstood something. > I removed the initial snapping, but with > in outline mode you sometimes (or maybe always) get initial > snapping because some EnterNotify or LeaveNotify event triggers a > faked motion event. This does not happen in opaque mode. This is the part that I thought would require more changes to fix. Obviously, I use outline mode, which is why I noticed the inconsistency. So I guess with your patch, it will still happen, but at least the final placement will agree with the outline. (Indeed, I tested, and this is what happens.) Thanks for your attention. Andrew
