As far as I know, you can make the pull request and I'll still get it.

What I suggest is that you put a message in there that refers to the branch of milestones/exceptions. There are not alot of pull requests coming in currently, so it is easy enough to see what is what.

Thanks!
Ralph

On 9/24/10 7:47 AM, Michael Ridgway wrote:
There is currently a bug in Github's pull request system that doesn't allow
us to make a request using the milestone/exception branch as a base:
http://support.github.com/discussions/repos/4165-bug-in-pull-request-base-selection

Is there another option that we have until this is fixed?

- Michael Ridgway

On Fri, Sep 24, 2010 at 8:43 AM, Matthew Weier O'Phinney
<matt...@zend.com>wrote:

-- Daniel Latter<dan.lat...@gmail.com>  wrote
(on Friday, 24 September 2010, 09:12 AM +0100):
I have made the amendments you suggested. Sorry to say I only scan read
the
post you linked to the other day on zfdev so im gonna read that properly
tonight :)

I am using Git Bash for windows with Github as my remote repo. I
currently
have all the changes in a separate branch of my master zf2 branch (forked
from zendFramework).

Should I commit my changes to milestones/exceptions branch on Github? If
so
how do I commit to a branch on Github using Git Bash, cant seem to get do
it?

No -- issue a pull request to the zendframework/zf2 repo, indicating the
milestones/exceptions branch. Ralph will then review, merge, and push.

Thanks in advance!

--
Matthew Weier O'Phinney
Project Lead            | matt...@zend.com
Zend Framework          | http://framework.zend.com/
PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc


Reply via email to