On Jul 25, 2013, Ilya Tumaykin wrote: > Hello everyone.
Hello Ilya, > After recent fwknopd upgrade to 2.5 I stumbled upon a new and unwanted > behavior. fwknopd now prints a warning if the file that is specified via > `--pid- > file` option doesn't exist prior to start. The printed message is: "Error > trying to open PID file: : No such file or directory" > > This message is printed both in foreground and daemon modes and is caused by > get_running_pid() call from fwknopd. This call prints the warning if internal > open() fails which is the case when pidfile is missing. > > Though, normal program flow is not interrupted in any way by this warning it > is > a bit confusing and unexpected, because usually daemons silently create > missing pidfiles. Moreover, it becomes common nowadays to store pidfiles in > '/run' directory which is usually mounted on tmpfs, so pidfiles are not > preserved during machine reboots. > > While having open() errors printed from get_running_pid() is convenient in > some cases, for example, when we check fwknopd status, it is not the greatest > idea to print them during daemon start, which is by the way caused by this > line from fwknopd.c file: if(get_running_pid(&opts) != getpid()). > > Please do something about it. I think the most trivial fix is to hide this > error under '-v' option. Understood and agree. fwknop-2.5.1 is coming shortly to fix one other issue as well. Thanks, --Mike > -- > Best regards. > Tumaykin Ilya. ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Fwknop-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/fwknop-discuss
