Sounds great - Dannon merged your pull request (https://bitbucket.org/galaxy/galaxy-central/pull-request/560/use-first-component-of-x-forwarded-for/diff) this morning. Thanks for the fix.
-John On Mon, Nov 24, 2014 at 5:30 AM, Jan Kanis <jan.c...@jankanis.nl> wrote: > Hi John, > > The change in galaxy and the one in routes are two independent instances of > the same problem, so the change in the galaxy PR can be merged immediately. > It just won't solve my original problem without the routes changes. > > Jan > > On 19 November 2014 at 15:33, John Chilton <jmchil...@gmail.com> wrote: >> >> Hey Jan, >> >> Thanks for the fixes. Sorry no one responded to your earlier e-mail. >> I think the pull request should serve as contact point on this - it >> cannot be merged until this >> (https://github.com/bbangert/routes/pull/33) is fixed and Galaxy >> updated to target it right? >> >> On Thu, Nov 13, 2014 at 11:02 AM, Jan Kanis <jan.c...@jankanis.nl> wrote: >> > Hi, >> > >> > We ran into a problem if galaxy is running behind multiple reverse >> > proxies. >> > Galaxy assumes that the X-Forwarded-Host header only contains a single >> > host >> > to which it redirects, but apache will append comma-separated components >> > to >> > it if it already exists, which is the case of multiple reverse proxies. >> > The >> > result is that galaxy sometimes (i.e. sometimes after user login, >> > depending >> > on browser specifics, and when installing toolshed tools) tries to >> > redirect >> > the browser to "hostname, hostname". Apache docs >> > >> > I have a patch for galaxy in this pull request. That change fixes a file >> > that makes the same assumption. The actual fix requires a change in >> > Routes. >> > The Routes PR is here, so actually fixing this requires an update of >> > Routes >> > after that pr is merged there. >> > >> > Jan >> > >> > >> > >> > ___________________________________________________________ >> > Please keep all replies on the list by using "reply all" >> > in your mail client. To manage your subscriptions to this >> > and other Galaxy lists, please use the interface at: >> > http://lists.bx.psu.edu/ >> > >> > To search Galaxy mailing lists use the unified search at: >> > http://galaxyproject.org/search/mailinglists/ > > ___________________________________________________________ Please keep all replies on the list by using "reply all" in your mail client. To manage your subscriptions to this and other Galaxy lists, please use the interface at: https://lists.galaxyproject.org/ To search Galaxy mailing lists use the unified search at: http://galaxyproject.org/search/mailinglists/
