On Wed, Oct 19, 2011 at 4:53 AM, Florent Angly <florent.an...@gmail.com> wrote: > > I have had the chance to try the patch on several datasets and it looks good > :) > I reiterate my suggestion to pull the patch in galaxy-central. > Best, > Florent
It looks sensible, although I would add a comment to the join method to say the description from read1 is taken (if the reads differ in their descriptions). Mind you, the whole module seems to lack docstrings ;) Are there any unit tests (not that Galaxy seems to insist on them)? Peter ___________________________________________________________ The Galaxy User list should be used for the discussion of Galaxy analysis and other features on the public server at usegalaxy.org. Please keep all replies on the list by using "reply all" in your mail client. For discussion of local Galaxy instances and the Galaxy source code, please use the Galaxy Development list: http://lists.bx.psu.edu/listinfo/galaxy-dev To manage your subscriptions to this and other Galaxy lists, please use the interface at: http://lists.bx.psu.edu/
