On Wed, Sep 10, 2008 at 10:38 AM, Alexander Schreiber <[EMAIL PROTECTED]> wrote: > On Tue, Sep 9, 2008 at 10:57 AM, Guido Trotter <[EMAIL PROTECTED]> wrote: >> On Tue, Sep 9, 2008 at 4:49 PM, Alexander Schreiber <[EMAIL PROTECTED]> >> wrote: >>> >>> Hello [email protected], >>> >>> I'd like you to do a code review on the patch below: >>> >>> Make burnin aware of hvm device type flags >>> >> >> LGTM... Would it make sense to make these flags mandatory, so that we >> would immediately notice if we miss them? > > As for making them mandatory: they are only relevant for HVM. > >> (or have a sensible default, otherwise) > > Well ... the command line interface does that, burnin only blew up > because it used the internal API ;-)
Yeah, but if the internal api is resilient to this we're safer... > To avoid that, I'd have to either move the "if not set use default" logic > from the command line interace to cmdlib.py or accept None and > use defaults when writing the hypervisor config (the later of > which currently is done to be compatible with existing instances). > You can probably set defaults, if missing, in both places... Thanks, Guido
