Re: [PATCH 05/21] Add new query to get cluster config values

[Michael Hanselmann]

2008/9/26 Iustin Pop <[EMAIL PROTECTED]>:
> One question: do you thik the REQ_QUERY_CONFIG_VALUES is flexible enough
> even if we change the cluster parameters (I think yes, just checking).

I don't see a reason why it shouldn't. After all, it doesn't say how
parameters are retrieved. E.g. the LU could do more complicated work
to retrieve the value(s).

> Here, we don't need to RPC to any node to get this, so they are 'static'
> fields. The difference between static and dynamic is:
>  - statis is from the config
>  - dynamic is from asking the nodes

Interdiff:

diff --git a/lib/cmdlib.py b/lib/cmdlib.py
index 4a9fd4a..f9b09b9 100644
--- a/lib/cmdlib.py
+++ b/lib/cmdlib.py
@@ -1869,9 +1869,9 @@ class LUQueryConfigValues(NoHooksLU):
   def ExpandNames(self):
     self.needed_locks = {}

-    dynamic_fields = ["cluster_name", "master_node"]
-    _CheckOutputFields(static=[],
-                       dynamic=dynamic_fields,
+    static_fields = ["cluster_name", "master_node"]
+    _CheckOutputFields(static=static_fields,
+                       dynamic=[],
                        selected=self.op.output_fields)

   def CheckPrereq(self):

Regards,
Michael