Re: [PATCH] Include node name in hypervisor validation errors

[Iustin Pop]

On Mon, May 04, 2009 at 01:30:12PM +0200, Iustin Pop wrote:
> The current validation routine just says "failed", without specifying
> the node name. This is very confusing, and we should log the node name
> too.
> ---
>  lib/cmdlib.py |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/cmdlib.py b/lib/cmdlib.py
> index 0e2e184..a39e85e 100644
> --- a/lib/cmdlib.py
> +++ b/lib/cmdlib.py
> @@ -4234,8 +4234,8 @@ def _CheckHVParams(lu, nodenames, hvname, hvparams):
>        continue
>      msg = info.RemoteFailMsg()
>      if msg:
> -      raise errors.OpPrereqError("Hypervisor parameter validation failed:"
> -                                 " %s" % msg)
> +      raise errors.OpPrereqError("Hypervisor parameter validation"
> +                                 " failed on node %s:" " %s" % (node, msg))

Gah, double-double-quotes. The proper patch is:
diff --git a/lib/cmdlib.py b/lib/cmdlib.py
index 0e2e184..516483e 100644
--- a/lib/cmdlib.py
+++ b/lib/cmdlib.py
@@ -4234,8 +4234,8 @@ def _CheckHVParams(lu, nodenames, hvname, hvparams):
       continue
     msg = info.RemoteFailMsg()
     if msg:
-      raise errors.OpPrereqError("Hypervisor parameter validation failed:"
-                                 " %s" % msg)
+      raise errors.OpPrereqError("Hypervisor parameter validation"
+                                 " failed on node %s: %s" % (node, msg))


iustin