On Tue, May 05, 2009 at 02:16:52PM +0100, Carlos Valiente wrote:
>
> Python 2.6 complains about module 'sha' being deprecated. It makes
> execution of Ganeti commands a bit annoying, and when you run
> 'ganeti-watcher' in cron jobs, you get a mail message after every
> execution.
>
> Tests pass under under Python 2.6 and Python 2.4.
>
> Cheers,
>
> Carlos Valiente
>
> ---
Look ok, with a small comment:
> +try:
> + from hashlib import sha1
> +except ImportError:
> + import sha
> + def sha1(*args):
> + return sha.new(*args)
The above could simply be rewritten as:
sha1 = sha.new
(instead of the 'def' part).
Could you retest and resend please?
thanks,
iustin
