On Mon, Jun 29, 2009 at 01:12:08PM +0100, Guido Trotter wrote:
> 
> If an empty string is passed to _SplitKeyVal, we should return {},
> rather than {'': True}. Also test for the correct behavior.
> 
> Signed-off-by: Guido Trotter <[email protected]>
> ---
>  lib/cli.py                  |   27 ++++++++++++++-------------
>  test/ganeti.cli_unittest.py |    4 ++++
>  2 files changed, 18 insertions(+), 13 deletions(-)

LGTM. We could also exit early from the function, i.e. if not data: return {}

iustin

Reply via email to