2009/9/22 Guido Trotter <[email protected]>: > On Tue, Sep 22, 2009 at 10:19 AM, Iustin Pop <[email protected]> wrote: >> Hmm, we are under the same issue as having two instances, one named >> instance1.example and the other instance1.example.com, which ganeti allows at >> create time but it completely breaks: >> >>>>> from ganeti.utils import MatchNameComponent >>>>> MatchNameComponent("a", ["a", "a.b"]) >>>>> MatchNameComponent("a.b", ["a", "a.b"]) >> 'a.b'
> Does it break? It seems to be the correct behavior! (if you can't > decide which one is it, decide there is no match). I agree that there should be no match in this case. >> We could also add a note in the man page and in the install/admin guide that >> it's not recommended to have such instances. Would that suffice? > Definitely. Not many people would be using uuids anyway... We could > also have an UUID regexp and abort at instance creation time if you > try to create a new instance with a UUID as its name (and maybe alert > in cluster verify if there is already one)? I agree with this one, too. We should also abort or at least warn on instance names with uppercase characters (only on creation, though). Regards, Michael
