2009/9/23 Guido Trotter <[email protected]>:
> --- a/lib/confd/client.py
> +++ b/lib/confd/client.py
> + def __call__(self, up):
> + salt = up.salt
> + filter = False
“filter” is a built-in.
> + if new_answer.answer != old_answer.answer:
> + self._logger.debug("Got incoherent answers for query %s"
> + " (serial: %s)" % (salt, new_answer.serial))
> + else:
> + self._logger.debug("Filtering confirming answer, with same"
> + " serial for query %s" % salt)
Please re-wrap or even move the whole “if self._logger:” thing into a
separate function.
> + else:
> + filter = True
> + if self._logger:
> + self._logger.debug("Filtering outdated answer for query %s"
> + " serial: (%d < %d)" % (salt, old_answer.serial,
> new_answer.serial))
Same here.
> + if not filter:
> + return self._callback(up)
> + else:
> + return
Why two types of return values?
Regards,
Michael
