2009/11/25 Iustin Pop <[email protected]>: > On Wed, Nov 25, 2009 at 10:40:10AM +0000, Michael Hanselmann wrote: >> 2009/11/25 Iustin Pop <[email protected]>: >> > Commit 6915bc2 removed utils.CommaJoin and replaced it with hardcoded >> > calls to " ,".join. However, this is wrong, since the correct separator >> > is ", ". >> >> LGTM > > Actually, thinking back on 6915bc2, I would propose that we revert it, and > (even if longer) try to use it always, so that we have only one place for > list→string formatting. What do you say?
LGTM. In some places it would be good to use quoting, in others it should not or can not be used. So having only one place may not be the best solution for all cases. CommaJoin could have an optional parameter (“quote=True”) to solve this, though. Regards, Michael
