2009/11/25 Iustin Pop <[email protected]>:
> This patch adds the 'cache' parameter for KVM; currently this is only
> customisable at the hypervisor level, so it's the same for all drives
> (except any CDROM image, which gets the default).
LGTM for 2.2.
> --- a/lib/hypervisor/hv_kvm.py
> +++ b/lib/hypervisor/hv_kvm.py
> + # Cache mode
> + disk_cache = hvp[constants.HV_DISK_CACHE]
> + if disk_cache != constants.HT_CACHE_DEFAULT:
> + cache_val = ",cache=%s" % disk_cache
> + else:
> + cache_val = ""
> for cfdev, dev_path in block_devices:
> if cfdev.mode != constants.DISK_RDWR:
> raise errors.HypervisorError("Instance has read-only disks which"
> @@ -323,7 +331,8 @@ class KVMHypervisor(hv_base.BaseHypervisor):
> else:
> boot_val = ''
>
> - drive_val = 'file=%s,format=raw%s%s' % (dev_path, if_val, boot_val)
> + drive_val = 'file=%s,format=raw%s%s%s' % (dev_path, if_val, boot_val,
> + cache_val)
I think this would be a good place to use a list and ",".join.
Regards,
Michael
