On Thu, Nov 26, 2009 at 5:46 PM, Iustin Pop <[email protected]> wrote: > On Thu, Nov 26, 2009 at 05:41:02PM +0100, Guido Trotter wrote: >> This shouldn't happen, but if it does it's better to fail at this level, >> rather than create a broken NIC script, which is hard to debug. > > LGTM for this patch, but please also add checks in Config.VerifyConfig > and (if there are none) in LUSetInstanceParms. >
There are checks in LUSetInstanceParms, but not in VerifyConfig currently. The ones in SetClusterParams were missing before 90b704a118cd101164e75b47b48a06476f8af1f3 though Thanks, Guido
