On Wed, Dec 9, 2009 at 11:38 AM, Iustin Pop <[email protected]> wrote: > On Tue, Dec 08, 2009 at 02:58:21PM +0000, Guido Trotter wrote: >> These represent our default routing table and its associated neighbour >> interface. >> >> Signed-off-by: Guido Trotter <[email protected]> >> --- >> lib/constants.py | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/lib/constants.py b/lib/constants.py >> index bd9d8f1..fa398ab 100644 >> --- a/lib/constants.py >> +++ b/lib/constants.py >> @@ -24,3 +24,5 @@ RELEASE_VERSION = _autoconf.PACKAGE_VERSION >> CONF_DIR = _autoconf.PKGSYSCONFDIR >> DEFAULT_CONF_FILE = CONF_DIR + "/common.conf" >> >> +DEFAULT_ROUTING_TABLE="100" >> +DEFAULT_NEIGHBOUR_INTERFACE="gtun0" > > Now I don't mind about gtun0, but 100? Maybe an autoconf level constant? > > Otherwise, if this is easily changeable, will be there be docs about this > '100'?
This is just a default, used if no config file has values about it. The example config file explains what this value represents. Is that enough? Another option is to remove the default, and force users to specify the value in the config file. Thanks, Guido
