On Tue, Jan 12, 2010 at 11:33 AM, Iustin Pop <[email protected]> wrote: > On Tue, Jan 12, 2010 at 11:31:20AM +0000, Guido Trotter wrote: >> On Tue, Dec 22, 2009 at 2:21 PM, Iustin Pop <[email protected]> wrote: >> > So, in the race between new hypervisor options and ganeti we can never >> > win - we always have to react post-fact and add a new parameter. >> > >> > In an attempt to compensate for this, I would propose that we add a new >> > hypervisor parameter (ley's say genparm) that is a list of (bool, >> > string) tuples. >> > >> > If the bool field is True, then the string parameter is added to the >> > command line. If the bool field is False, and the parameter exists >> > (e.g. a hardcoded acpi=True), then the parameter is removed. >> > >> > For KVM, this would mean extra command line parameters. For Xen, extra >> > config file values. Ganeti itself would not interpret these in any way. >> > >> > Of course, this would allow really breaking the hypervisor if used >> > carelessly but it would a perfect addition until a new version of ganeti >> > adds specific handling for a parameter. >> >> Sounds like a good idea! But should we also have (string,string) >> tuples, to implement -flag=value behavior? > > Hmm, no, my proposal is different. (bool, string) means (True, > "flag=value") to add (for KVM) "-flag=value" and for xen "flag=value", > and (False, "flag=value") means removing it from the configs. > > In other words, we don't split the value, just pass it to the > hypervisor.
Ah, sounds good, I hadn't understood that!! Thanks, Guido
