On Mon, Feb 22, 2010 at 10:57, Guido Trotter <[email protected]> wrote:
> On Tue, Feb 9, 2010 at 1:35 PM, Balazs Lecz <[email protected]> wrote: > > > > Signed-off-by: Balazs Lecz <[email protected]> > > LGTM > > > --- > > Makefile.am | 3 +- > > autotools/run-in-tempdir | 1 + > > daemons/ganeti-nld | 1 + > > lib/nflog_dispatcher.py | 58 > ++++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 62 insertions(+), 1 deletions(-) > > create mode 100644 lib/nflog_dispatcher.py > > > > diff --git a/Makefile.am b/Makefile.am > > index c8890fa..757b897 100644 > > --- a/Makefile.am > > +++ b/Makefile.am > > @@ -30,7 +30,8 @@ pkgpython_PYTHON = \ > > lib/config.py \ > > lib/iptables.py \ > > lib/networktables.py \ > > - lib/server.py > > + lib/server.py \ > > + lib/nflog_dispatcher.py > > > > nodist_pkgpython_PYTHON = \ > > lib/_autoconf.py > > diff --git a/autotools/run-in-tempdir b/autotools/run-in-tempdir > > index 6f620e6..468ddc3 100755 > > --- a/autotools/run-in-tempdir > > +++ b/autotools/run-in-tempdir > > @@ -7,5 +7,6 @@ trap "rm -rf $tmpdir" EXIT > > > > cp -r scripts lib test $tmpdir > > mv $tmpdir/lib $tmpdir/ganeti_nbma > > +cp -r ganeti.git/lib $tmpdir/ganeti > > > > Except this change should have probably been in a separate patch. > Or at least documented in the changelog. :) > You mean the "cp -r ganeti.git/lib $tmpdir/ganeti"? If so, I agree. I'll put in a comment about it: "Add a missing step that copies the Ganeti library into the test tempdir" /leczb
