On Thu, Mar 18, 2010 at 12:19, Guido Trotter <[email protected]> wrote:
> On Wed, Feb 17, 2010 at 04:59:53PM +0000, Balazs Lecz wrote:
>
> Hi,
>
> > # Injecting ourselves in the ganeti constants
> > gnt_constants.NLD = constants.NLD
> > gnt_constants.DAEMONS_LOGFILES[constants.NLD] = gnt_constants.LOG_DIR +
> "nl-daemon.log"
> > +gnt_constants.DAEMONS_PORTS[constants.NLD] = ("udp", 1816)
> >
>
> Not needed anymore in 2.1.1
>
Do you mean I should remove all three gnt_constants.* = ... lines (in this
patch)?
>
> Rest LGTM, except for the comment in later patches (let's settle down here
> if
> we're using classes or methods, for the queries). Also, it would be nice if
> the
> protocol and query list was documented under doc/ in a similar manner to
> the
> confd ones, under ganeti/doc/design-2.1.rst
>
> (but could be in this case doc/nld-nld-protocol.rst)
>
> Thanks,
>
> Guido
>
