On Fri, Apr 16, 2010 at 02:47:05PM +0200, Michael Hanselmann wrote:
> 2010/4/16 Iustin Pop <[email protected]>:
> > On Wed, Apr 07, 2010 at 06:44:30PM +0200, Michael Hanselmann wrote:
> >> --- a/lib/backend.py
> >> +++ b/lib/backend.py
> >> +def _OpenRealBD(disk):
> > […]
> >
> > This is a generic cleanup that is good to apply to devel-2.1. Would you
> > mind doing this (_OpenRealDB) in a separate patch?
>
> Done, commit f2e07bb4422196739afc07a9520856d7925686df.
>
> All other comments have been addressed in this interdiff:
> diff --git a/lib/rpc.py b/lib/rpc.py
> index a290ae5..b99b49e 100644
> --- a/lib/rpc.py
> +++ b/lib/rpc.py
> @@ -1268,6 +1268,9 @@ class RpcRunner(object):
> @param node: Node name
> @type names: List of strings
> @param names: Import/export names
> + @rtype: List of L{objects.ImportExportStatus} instances
I think here you need ganeti.objects.…, otherwise epydoc will complain.
LGTM
--
Subscription settings:
http://groups.google.com/group/ganeti-devel/subscribe?hl=en
