On Mon, Jun 14, 2010 at 06:31:36PM +0100, Guido Trotter wrote: > On Mon, Jun 14, 2010 at 6:23 PM, Iustin Pop <[email protected]> wrote: > > Oh, this is not a problem at all. In my other patch series, this > > function gets two new parameters, 'use_default' which tells whether to > > remove values matching constants.VALUE_DEFAULT, and 'use_node', which > > tells whether to remove values equal to None (which is how cli.py passes > > today already parameters of the form "-val"). > > > > I can change the name, if you really want (~18 patches to rebase :), but > > it's not a problem). > > Could you change it at the end of the series, perhaps, if we find > something better? That way you don't have to rebase and it becomes a > simple replacement around cmdlib.py.
Sounds good to me. > For now, LGTM. I'll take this as an LGTM for master, thanks! iustin
