On Mon, Jun 14, 2010 at 02:28:55PM +0100, Guido Trotter wrote: > This doesn't conflict with any other parallel operation (itself and > SubmitJob) and so it can happen with just the acquire change, for now. > > Signed-off-by: Guido Trotter <[email protected]> > --- > lib/jqueue.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/jqueue.py b/lib/jqueue.py > index 882cc8b..ae0d4f9 100644 > --- a/lib/jqueue.py > +++ b/lib/jqueue.py > @@ -1140,7 +1140,7 @@ class JobQueue(object): > # Notify waiters about potential changes > job.change.notifyAll() > > - @locking.ssynchronized(_big_jqueue_lock) > + @locking.ssynchronized(_big_jqueue_lock, shared=1) > @_RequireOpenQueue > def WaitForJobChanges(self, job_id, fields, prev_job_info, prev_log_serial, > timeout):
Seems trivial, but is it? LGTM :) iustin
