Re: [PATCH master] Introduce lib/netutils.py

[Manuel Franceschini]

On Tue, Jul 6, 2010 at 6:08 PM, Manuel Franceschini <livew...@google.com> wrote:
> This patch moves network utility functions to a dedicated module.
>
> Signed-off-by: Manuel Franceschini <livew...@google.com>
> ---

[...]

After fixing small bug below it passes QA.

diff --git a/lib/bootstrap.py b/lib/bootstrap.py
index 8ffe537..8c98275 100644
--- a/lib/bootstrap.py
+++ b/lib/bootstrap.py
@@ -566,7 +566,7 @@ def MasterFailover(no_voting=False):
   total_timeout = 30
   # Here we have a phase where no master should be running
   def _check_ip():
-    if utils.TcpPing(master_ip, constants.DEFAULT_NODED_PORT):
+    if netutils.TcpPing(master_ip, constants.DEFAULT_NODED_PORT):
       raise utils.RetryAgain()

   try:


Manuel