LGTM, Thanks,
Guido On 29 Jul 2010 14:54, "Iustin Pop" <[email protected]> wrote: > Since we don't support upgrades from 1.2.4 without restarting the > instance, the 'not restarted since 1.2.5' check/error is > wrong/misleading. > > Since the live migration works anyway without the links (it recreates > them during the disk reconfiguration anyway), we remove the check and we > transform it into a warning (to the node daemon log only, > unfortunately). > > For 2.3, we'll need to change the symlink creation from instance start > time to disk activation time (but that requires more RPC changes). > --- > lib/backend.py | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/lib/backend.py b/lib/backend.py > index 311c984..5b2bebd 100644 > --- a/lib/backend.py > +++ b/lib/backend.py > @@ -805,7 +805,8 @@ def GetInstanceMigratable(instance): > for idx in range(len(instance.disks)): > link_name = _GetBlockDevSymlinkPath(iname, idx) > if not os.path.islink(link_name): > - _Fail("Instance %s was not restarted since ganeti 1.2.5", iname) > + logging.warning("Instance %s is missing symlink %s for disk %d", > + iname, link_name, idx) > > > def GetAllInstancesInfo(hypervisor_list): > -- > 1.7.1 >
