On Fri, Sep 24, 2010 at 9:46 AM, Serge van Ginderachter <[email protected]> wrote:
Hi, Yes, we have received your patch and everything is fine. As for the changes: > +# depending on your version of passwd, chpasswd can use the -e flag > to handle en encrypted password. you probably want to use that. Ok. (will split in two lines) > + > cat $(dirname $0)/confdata/defaultpasswords | chroot $TARGET chpasswd > Perhaps I'll change this to chroot $TARGET chpasswd < $(dirname $0)/confdata/defaultpasswords > diff --git a/examples/hooks/timezone b/examples/hooks/timezone > index ff6c968..2214c7c 100755 > --- a/examples/hooks/timezone > +++ b/examples/hooks/timezone > @@ -1,8 +1,11 @@ > #!/bin/sh > # > -# This is an example script that sets the timezone to a given default > +# This is an example script that sets the timezone to a given > default, or to the one of the host is none is configured > > -cp confdata/timezone $TARGET/etc/ > -chroot $TARGET dpkg-reconfigure --frontend noninteractive tzdata > +if [ -r confdata/timezone ] > +then cp confdata/timezone $TARGET/etc/ > +else cp /etc/timezone $TARGET/etc/ > +fi > Will the file actually exist? "timezone" is not actually guaranteed to be executed with the hooks dir as its current directory > +chroot $TARGET dpkg-reconfigure --frontend noninteractive tzdata > Thanks, Guido
