On Thu, Sep 30, 2010 at 02:09:31PM +0200, Michael Hanselmann wrote: > Hi > > Am 29. September 2010 20:00 schrieb Iustin Pop <[email protected]>: > > On Wed, Sep 29, 2010 at 06:45:28PM +0200, Michael Hanselmann wrote: > >> Since JSON doesn't support comments, the dictionary key for > >> disabled tests is prefix with a hash sign (#). This is already > >> done for other commented out entries. > > > > But this makes it harder to use the provided example file. Can't you > > leave the tests as is (i.e. enabled both in the config file and in the > > code)? > > The example file can still be used as it is (at least the list of > tests).
I know this. I was referring to the fact to it doesn't contain the actual keys that are used. > If we leave it as it is one wants to disable a test, one has > to replace “true” with “false” (or 0). With my proposed change, one > has to remove the “#” character only, as the default is to run all > tests unless explicitely disabled: Yes, but I think having the proper keys would be more useful, as for example if we added some consistency checks to ganeti_qa.py. Don't really care, so LGTM, but I think it's a needless change. iustin
