On Thu, Sep 30, 2010 at 06:15:34PM +0200, Michael Hanselmann wrote:
> Am 30. September 2010 16:45 schrieb Iustin Pop <[email protected]>:
> > On Thu, Sep 30, 2010 at 02:20:12PM +0200, Michael Hanselmann wrote:
> >> -No parameters are required, but the bool parameter ``live`` can be set
> >> -to use live migration (if available).
> >> +Query parameters:
> >> +
> >> +``live`` (bool)
> >> +  If set, use live migration if available.
> >> +``mode`` (string)
> >> +  Sets migration mode, ``live`` for live migration and ``non-live`` for
> >> +  non-live migration. Supported by Ganeti 2.2 and above.
> >
> > LGTM. Probably we should also document that not passing it uses the
> > default configuration for the hypervisor of each instance (this is
> > probably non-obvious).
> 
> That'd belong into the opcode's documentation, but … yes. Will commit
> with this interdiff:

LGTM, thanks (I like LGTMing things :).

iustin

Reply via email to